[PATCH] ASoC: rt5682s: Separate the regulator consumer controls

Mark Brown broonie at kernel.org
Fri Mar 25 14:10:48 CET 2022


On Fri, Mar 25, 2022 at 03:55:32PM +0800, derek.fang at realtek.com wrote:

> @@ -3025,8 +3025,17 @@ static struct snd_soc_dai_driver rt5682s_dai[] = {
>  static void rt5682s_i2c_disable_regulators(void *data)
>  {
>  	struct rt5682s_priv *rt5682s = data;
> +	int ret;
> +
> +	ret = regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_AVDD].consumer);
> +	if (ret)
> +		pr_err("%s: Failed to disable supply AVDD: %d\n", __func__, ret);

Please use dev_err() for error reporting.  Otherwise this looks fine.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220325/5a40f0c8/attachment.sig>


More information about the Alsa-devel mailing list