[bug report] ASoC: atmel: mchp-pdmc: add PDMC driver
Dan Carpenter
dan.carpenter at oracle.com
Thu Mar 10 15:49:15 CET 2022
Hello Codrin Ciubotariu,
The patch 50291652af52: "ASoC: atmel: mchp-pdmc: add PDMC driver"
from Mar 7, 2022, leads to the following Smatch static checker
warning:
sound/soc/atmel/mchp-pdmc.c:186 mchp_pdmc_af_put()
warn: this array is probably non-NULL. 'uvalue->value.integer.value'
sound/soc/atmel/mchp-pdmc.c
181 static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
182 struct snd_ctl_elem_value *uvalue)
183 {
184 struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
185 struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);
--> 186 bool af = uvalue->value.integer.value ? true : false;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
value is an array, not a pointer. It's always going to be non-NULL.
187
188 if (dd->audio_filter_en == af)
189 return 0;
190
191 dd->audio_filter_en = af;
192
193 return 1;
194 }
regards,
dan carpenter
More information about the Alsa-devel
mailing list