> +enum avs_i2s_version { > + AVS_I2S_VER_15_SKYLAKE = 0x00000, > + AVS_I2S_VER_15_BROXTON = 0x10000, I would add a comment that this is added for completeness but not tested/supported. > + AVS_I2S_VER_15_BROXTON_P = 0x20000, > + AVS_I2S_VER_18_KBL_CNL = 0x30000, > +};