[PATCH v3 10/17] ASoC: Intel: avs: Add basefw runtime-parameter requests

Ranjani Sridharan ranjani.sridharan at linux.intel.com
Mon Mar 7 18:06:35 CET 2022


On Mon, 2022-03-07 at 18:02 +0100, Cezary Rojewski wrote:
> > What could make it simpler is if you allocate MAX IPC size for
> > payload
> > in this function and then copy the right size in the
> > avs_ipc_get_large_config(). payload_size tells you that information
> > anyway right?
> 
> 
> 
> 
> As stated, there is no clear winner here - you had to repeat such
> code 
> 
> for every getter.
> 
> 
> 
> Since we are getting payload_size already, retrieving payload itself
> is 
> 
> just fine.

OK, can you please add a comment to state this in the patch so the
reviewer doesnt have to track down where this memory is allocated?

Thanks,Ranjani



More information about the Alsa-devel mailing list