[PATCH 2/4] ASoC: amd: pcm-dma: Fix signedness bug in acp_pdm_audio_probe()
Dan Carpenter
dan.carpenter at oracle.com
Fri Mar 4 14:13:35 CET 2022
The "adata->pdm_irq" variable is unsigned so the error handling will
not work.
Fixes: 87d71a128771 ("ASoC: amd: pcm-dma: Use platform_get_irq() to get the interrupt")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
sound/soc/amd/renoir/acp3x-pdm-dma.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c
index 88a242538461..8c42345ee41e 100644
--- a/sound/soc/amd/renoir/acp3x-pdm-dma.c
+++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c
@@ -399,9 +399,10 @@ static int acp_pdm_audio_probe(struct platform_device *pdev)
if (!adata->acp_base)
return -ENOMEM;
- adata->pdm_irq = platform_get_irq(pdev, 0);
- if (adata->pdm_irq < 0)
- return -ENODEV;
+ status = platform_get_irq(pdev, 0);
+ if (status < 0)
+ return status;
+ adata->pdm_irq = status;
adata->capture_stream = NULL;
--
2.20.1
More information about the Alsa-devel
mailing list