[PATCH] wm8962: add a simple DMIC enable control

[Martin Kepplinger]

Am Dienstag, dem 01.03.2022 um 15:00 +0100 schrieb Martin Kepplinger:
> Am Dienstag, dem 01.03.2022 um 13:44 +0000 schrieb Charles Keepax:
> > On Mon, Feb 07, 2022 at 02:21:29PM +0000, Charles Keepax wrote:
> > > On Mon, Feb 07, 2022 at 11:49:32AM +0100, Martin Kepplinger
> > > wrote:
> > > > Am Freitag, dem 04.02.2022 um 17:21 +0000 schrieb Charles
> > > > Keepax:
> > > > > On Fri, Feb 04, 2022 at 10:43:53AM +0100, Martin Kepplinger
> > > > > wrote:
> > > > Volume itself indeed is good now. Recorded voice is very
> > > > "metallic" and
> > > > "shallow" if you know what I mean - and distorted when using
> > > > MAX
> > > > volume. The gnome audio recorder doesn't show *any* signal in
> > > > the
> > > > UI,
> > > > so that must still be kind of bad - even though I understand
> > > > recorded
> > > > voice way better now than before.
> > > > 
> > > 
> > > My first thought is that the signal is clipping somewhere in the
> > > chain. You have a lot of the gaines up very high from when you
> > > were trying to working around the low signal level issues.
> > > 
> > > Can we be clear here on what paths are in play here. Presumably
> > > the gnome audio recorder is capturing over the I2S. When you say
> > > you can understand the recorded voice way better now, do you mean
> > > in the file captured by the gnome audio recorder? Or are you
> > > listening to that on another path, like direct to the headphones?
> > > 
> > > > thanks for all the time and help, and sorry for all the wrong
> > > > amixer
> > > > output I sent you,
> > > > 
> > > 
> > 
> > Hey, just wanted to check everything was going ok on this stuff?
> > Did the volume tweaks get things sounding more normal, and any
> > other problems you guys are having?
> > 
> > Thanks,
> > charles
> 
> Hi Charles!
> 
> that's really nice of you to ask. Sorry for not replying earlier.
> Mainly cset "name='MIXINR PGA Volume' 0,0" made things much better
> indeed. I took a break from this then and the issue is still open,
> here:
> https://source.puri.sm/Librem5/librem5-base/-/merge_requests/296
> or if you want to look at the current ucm file:
> https://source.puri.sm/Librem5/librem5-base/-/blob/bb48912242dd0db1f35c6de8425984414c6d37bb/default/audio/ucm2/Librem_5/HiFi.conf
> 
> As you know I'm no expert with the codec and this definitely can be
> improved: When visualizing the signal, it doesn't look "good" yet and
> the signal strength seems to only go to 50% of the available scale
> (in
> the gnome volume setting). Actually I'll talk about this to Guido
> tomorrow and even though it is kind of usable now, I hope to that we
> can come up with a profile that we're preliminarliy happy with.
> 
> Of course we already use your "Input Mode" control.
> 
> thanks,
> 
>                                 martin
> 
> 

Hi Charles,

Let me forward the commit message I just did for the ucm settings here,
now that I have a *bit* of an overview of the codec:

There are 3 Volume controls for the analog parts, all before the ADC.
In order from Jack to ADC, they are:

numid=10,iface=MIXER,name='Capture Volume'
   ; type=INTEGER,access=rw---R--,values=2,min=0,max=63,step=0
   : values=63,63
   | dBscale-min=-23.25dB,step=0.75dB,mute=0

"Input PGA Volume Control". 31=0dB. We use 39=+6dB.


numid=7,iface=MIXER,name='MIXINR PGA Volume'
   ; type=INTEGER,access=rw---R--,values=1,min=0,max=7,step=0
   : values=7
   | dBrange-
     rangemin=0,,rangemax=1
       | dBscale-min=0.00dB,step=6.00dB,mute=0
     rangemin=2,,rangemax=2
       | dBscale-min=13.00dB,step=13.00dB,mute=0
     rangemin=3,,rangemax=4
       | dBscale-min=18.00dB,step=2.00dB,mute=0
     rangemin=5,,rangemax=5
       | dBscale-min=24.00dB,step=0.00dB,mute=0
     rangemin=6,,rangemax=7
       | dBscale-min=27.00dB,step=3.00dB,mute=0

"Right input PGA to Right input Boost-Mixer Gain"
0=0dB. we use 1=+3dB.


numid=8,iface=MIXER,name='MIXINR IN3R Volume'
  ; type=INTEGER,access=rw---R--,values=1,min=0,max=7,step=0
  : values=6
  | dBscale-min=-15.00dB,step=3.00dB,mute=0

5=0dB. we use 6=+3dB. That's a later amplifier, "Boost-Mixer Gain".

("quotes" are from the datasheet)

Still, the recording sounds pretty good I think, but since gnome sound-
recording doesn't visualize the signal waves - whatever that means :)
I'll look at the file in audacity or something similar later.


thanks for having a look,

                         martin