[PATCH v2] ASoC: fsi: Add check for clk_enable
Jiasheng Jiang
jiasheng at iscas.ac.cn
Wed Mar 2 04:09:00 CET 2022
As the potential failure of the clk_enable(),
it should be better to check it and return error
if fails.
Fixes: ab6f6d85210c ("ASoC: fsi: add master clock control functions")
Signed-off-by: Jiasheng Jiang <jiasheng at iscas.ac.cn>
---
Changelog:
v1 -> v2
* Change 1. Seperate the error handler.
---
sound/soc/sh/fsi.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
index cdf3b7f69ba7..91050478844a 100644
--- a/sound/soc/sh/fsi.c
+++ b/sound/soc/sh/fsi.c
@@ -816,14 +816,27 @@ static int fsi_clk_enable(struct device *dev,
return ret;
}
- clk_enable(clock->xck);
- clk_enable(clock->ick);
- clk_enable(clock->div);
+ ret = clk_enable(clock->xck);
+ if (ret)
+ goto err;
+ ret = clk_enable(clock->ick);
+ if (ret)
+ goto disable_xck;
+ ret = clk_enable(clock->div);
+ if (ret)
+ goto disable_ick;
clock->count++;
}
return ret;
+
+disable_xck:
+ clk_disable(clock->xck);
+disable_ick:
+ clk_disable(clock->ick);
+err:
+ return ret;
}
static int fsi_clk_disable(struct device *dev,
--
2.25.1
More information about the Alsa-devel
mailing list