回复:[PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq_byname()
Yang.Lee
yang.lee at linux.alibaba.com
Wed Mar 2 02:17:21 CET 2022
The function dev_err_probe() is called in function platform_get_irq_byname() to print the error code.
------------------------------------------------------------------
发件人:Mark Brown <broonie at kernel.org>
发送时间:2022年3月1日(星期二) 20:40
收件人:Yang Li <yang.lee at linux.alibaba.com>
抄 送:lgirdwood <lgirdwood at gmail.com>; perex <perex at perex.cz>; tiwai <tiwai at suse.com>; tangmeng <tangmeng at uniontech.com>; alsa-devel <alsa-devel at alsa-project.org>; linux-kernel <linux-kernel at vger.kernel.org>; Abaci Robot <abaci at linux.alibaba.com>
主 题:Re: [PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq_byname()
On Tue, Mar 01, 2022 at 02:49:20PM +0800, Yang Li wrote:
> - adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq");
> - if (adata->i2s_irq < 0)
> + adata->i2s_irq = ret = platform_get_irq_byname(pdev, "acp_dai_irq");
> + if (ret < 0)
> return -ENODEV;
If an error code is being returned we should report that error code
rather than squashing it down to -ENODEV.
More information about the Alsa-devel
mailing list