[PATCH] Asoc: au1x: Use devm_snd_soc_register_component()

Mark Brown broonie at kernel.org
Tue Mar 1 14:28:21 CET 2022


On Tue, Mar 01, 2022 at 05:23:22PM +0800, Zhen Ni wrote:

> +++ b/sound/soc/au1x/psc-ac97.c
> @@ -411,7 +411,7 @@ static int au1xpsc_ac97_drvprobe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	ret = snd_soc_register_component(&pdev->dev, &au1xpsc_ac97_component,
> +	ret = devm_snd_soc_register_component(&pdev->dev, &au1xpsc_ac97_component,
>  					 &wd->dai_drv, 1);
>  	if (ret)
>  		return ret;
> -- 

This introduces a double free since there is a remove() function which
calls snd_soc_unregister_component().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220301/97308a1a/attachment.sig>


More information about the Alsa-devel mailing list