[PATCH] ASoC: core: Make snd_soc_unregister_card() return void
kernel test robot
lkp at intel.com
Wed Jun 22 13:49:14 CEST 2022
Hi "Uwe,
I love your patch! Yet something to improve:
[auto build test ERROR on f2906aa863381afb0015a9eb7fefad885d4e5a56]
url: https://github.com/intel-lab-lkp/linux/commits/Uwe-Kleine-K-nig/ASoC-core-Make-snd_soc_unregister_card-return-void/20220621-230233
base: f2906aa863381afb0015a9eb7fefad885d4e5a56
config: xtensa-randconfig-r003-20220620 (https://download.01.org/0day-ci/archive/20220622/202206221950.PW6xhJO1-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/5a135ba83d6b991aae0eed01f26464524116abec
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Uwe-Kleine-K-nig/ASoC-core-Make-snd_soc_unregister_card-return-void/20220621-230233
git checkout 5a135ba83d6b991aae0eed01f26464524116abec
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash sound/soc/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_with_null_ops':
>> sound/soc/soc-topology-test.c:316:13: error: void value not ignored as it ought to be
316 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_with_null_fw':
sound/soc/soc-topology-test.c:380:13: error: void value not ignored as it ought to be
380 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_empty_tplg':
sound/soc/soc-topology-test.c:429:13: error: void value not ignored as it ought to be
429 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_empty_tplg_bad_magic':
sound/soc/soc-topology-test.c:485:13: error: void value not ignored as it ought to be
485 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_empty_tplg_bad_abi':
sound/soc/soc-topology-test.c:541:13: error: void value not ignored as it ought to be
541 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_empty_tplg_bad_size':
sound/soc/soc-topology-test.c:597:13: error: void value not ignored as it ought to be
597 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_empty_tplg_bad_payload_size':
sound/soc/soc-topology-test.c:656:13: error: void value not ignored as it ought to be
656 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_pcm_tplg':
sound/soc/soc-topology-test.c:705:13: error: void value not ignored as it ought to be
705 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_pcm_tplg_reload_comp':
sound/soc/soc-topology-test.c:758:13: error: void value not ignored as it ought to be
758 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
sound/soc/soc-topology-test.c: In function 'snd_soc_tplg_test_load_pcm_tplg_reload_card':
sound/soc/soc-topology-test.c:807:21: error: void value not ignored as it ought to be
807 | ret = snd_soc_unregister_card(&kunit_comp->card);
| ^
vim +316 sound/soc/soc-topology-test.c
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 280
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 281 /*
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 282 * NULL ops is default case, we pass empty topology (fw), so we don't have
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 283 * anything to parse and just do nothing, which results in return 0; from
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 284 * calling soc_tplg_dapm_complete in soc_tplg_process_headers
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 285 */
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 286 static void snd_soc_tplg_test_load_with_null_ops(struct kunit *test)
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 287 {
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 288 struct kunit_soc_component *kunit_comp;
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 289 int ret;
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 290
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 291 /* prepare */
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 292 kunit_comp = kunit_kzalloc(test, sizeof(*kunit_comp), GFP_KERNEL);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 293 KUNIT_EXPECT_NOT_ERR_OR_NULL(test, kunit_comp);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 294 kunit_comp->kunit = test;
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 295 kunit_comp->expect = 0; /* expect success */
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 296
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 297 kunit_comp->card.dev = test_dev,
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 298 kunit_comp->card.name = "kunit-card",
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 299 kunit_comp->card.owner = THIS_MODULE,
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 300 kunit_comp->card.dai_link = kunit_dai_links,
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 301 kunit_comp->card.num_links = ARRAY_SIZE(kunit_dai_links),
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 302 kunit_comp->card.fully_routed = true,
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 303
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 304 /* run test */
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 305 ret = snd_soc_register_card(&kunit_comp->card);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 306 if (ret != 0 && ret != -EPROBE_DEFER)
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 307 KUNIT_FAIL(test, "Failed to register card");
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 308
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 309 ret = snd_soc_component_initialize(&kunit_comp->comp, &test_component, test_dev);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 310 KUNIT_EXPECT_EQ(test, 0, ret);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 311
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 312 ret = snd_soc_add_component(&kunit_comp->comp, NULL, 0);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 313 KUNIT_EXPECT_EQ(test, 0, ret);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 314
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 315 /* cleanup */
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 @316 ret = snd_soc_unregister_card(&kunit_comp->card);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 317 KUNIT_EXPECT_EQ(test, 0, ret);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 318
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 319 snd_soc_unregister_component(test_dev);
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 320 }
d52bbf747cfa8a2 Amadeusz Sławiński 2021-01-20 321
--
0-DAY CI Kernel Test Service
https://01.org/lkp
More information about the Alsa-devel
mailing list