[PATCH 10/12] ALSA: seq: use correct format characters
Bill Wendling
morbo at google.com
Fri Jun 10 00:16:29 CEST 2022
From: Bill Wendling <isanbard at gmail.com>
When compiling with -Wformat, clang emits the following warnings:
sound/core/sound.c:79:17: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
request_module(str);
^~~
Use a string literal for the format string.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <isanbard at gmail.com>
---
sound/core/sound.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/sound.c b/sound/core/sound.c
index df5571d98629..7866f29621bf 100644
--- a/sound/core/sound.c
+++ b/sound/core/sound.c
@@ -76,7 +76,7 @@ static void snd_request_other(int minor)
case SNDRV_MINOR_TIMER: str = "snd-timer"; break;
default: return;
}
- request_module(str);
+ request_module("%s", str);
}
#endif /* modular kernel */
--
2.36.1.255.ge46751e96f-goog
More information about the Alsa-devel
mailing list