[PATCH 1/3] ASoC: wm8940: Remove warning when no plat data

Mark Brown broonie at kernel.org
Tue Jun 7 14:35:06 CEST 2022


On Tue, Jun 07, 2022 at 02:30:39PM +0200, Lukasz Majewski wrote:
> > On Mon, Jun 06, 2022 at 06:17:31PM +0200, Lukasz Majewski wrote:
> > > > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote:  

> > > My point is that - similar codec - wm8974 don't display such
> > > warnings. (this code was not updated/refactored for a quite long
> > > time).  

> > Perhaps those drivers are buggy, or those devices lack this specific
> > configuration that's being adjusted?  The changelog should at least
> > address why the driver was warning about configuration being required
> > but it's safe to ignore that.

> With v4.4 from which I forward port those changes only the PXA
> 'stargate2' mach is using this codec.

> In this version there is no reference to 'vroi'.

That's equivalent to setting a value of 0 given the way platform data
works.

> I guess that one can provide the 'vroi' information via DTS nowadays if
> required.

Yes, that's what I'd expect.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220607/02ab77c5/attachment-0001.sig>


More information about the Alsa-devel mailing list