[PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic

Venkata Prasad Potturu venkataprasad.potturu at amd.com
Fri Jul 29 12:43:39 CEST 2022


On 7/25/22 17:32, Mark Brown wrote:
Thanks for your time.
> On Mon, Jul 25, 2022 at 10:27:19AM +0000, Prasad, Prasad wrote:
>
>> This looks like it's just an indentation/formatting change which isn't
>>
>> what the changelog said?
>> We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances.
>>
>> To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02.
>> I2S_HS_INSTANCE is already 0x03.
> Please write a better changelog which makes this clear.
Okay, we will change accordingly.
>
> Please fix your e-mail client to clearly distinguish between quoted and
> non-quoted text, it's very hard to find your new text in your mail.


More information about the Alsa-devel mailing list