[PATCH 3/5] ASoC: amd: acp: Initialize list to store acp_stream during pcm_open

Prasad, Prasad venkataprasad.potturu at amd.com
Fri Jul 22 15:33:18 CEST 2022


[AMD Official Use Only - General]



On 7/22/2022 3:53 AM, Mark Brown wrote:
Thanks for you time Mark.

On Thu, Jul 21, 2022 at 11:50:35AM +0530, Venkata Prasad Potturu wrote:

From: Ajit Kumar Pandey <AjitKumar.Pandey at amd.com><mailto:AjitKumar.Pandey at amd.com>



We are currently allocating acp_stream during pcm_open and saving

it in static array corresponds to array index calculated based on

cpu dai->driver id. This approach will fail if we have single dai

linked to multiple pcm device as we will have same dai->driver id

or array index for multiple pcm open. Initialize new linked list

stream_list to store opened pcm stream info dynamically.

This breaks an x86 allmodconfig build:



/build/stage/linux/sound/soc/amd/acp/acp-platform.c: In function 'i2s_irq_handler':

/build/stage/linux/sound/soc/amd/acp/acp-platform.c:108:31: error: 'struct acp_dev_data' has no member named 'stream'

  108 |                 stream = adata->stream[i];

      |                               ^~

make[5]: *** [/build/stage/linux/scripts/Makefile.build:249: sound/soc/amd/acp/acp-platform.o] Error 1
Okay, will fix and send in next version.





More information about the Alsa-devel mailing list