[PATCH v8 01/14] ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls

[Takashi Iwai]

On Thu, 30 Jun 2022 02:23:22 +0200,
Vitaly Rodionov wrote:
> --- a/sound/pci/hda/Kconfig
> +++ b/sound/pci/hda/Kconfig
> @@ -94,6 +94,10 @@ config SND_HDA_PATCH_LOADER
>  config SND_HDA_SCODEC_CS35L41
>  	tristate
>  
> +config SND_HDA_CS_DSP_CONTROLS
> +	tristate
> +	depends on CS_DSP
> +
>  config SND_HDA_SCODEC_CS35L41_I2C
>  	tristate "Build CS35L41 HD-audio side codec support for I2C Bus"
>  	depends on I2C

This change alone doesn't give anything useful, unfortunately.

The above form (without prompt) is basically only to be "selected" by
others.  And when selected, the "depends" there is just ignored, so
it's useless.

That is, a proper way would be something like:

config SND_HDA_CS_DSP_CONTROLS
	tristate

config SND_HDA_SCODEC_CS35L41
	....
	select SND_HDA_CS_DSP_CONTROLS if CS_DSP

... if you want / need to enable CONFIG_SND_HDA_CS_DSP_CONTROLS
conditionally.


thanks,

Takashi