[PATCH] ASoC: dt-bindings: atmel-i2s: Convert to json-schema

[Krzysztof Kozlowski]

On 13/07/2022 18:25, Ryan.Wanner at microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner at microchip.com>
> 

Thank you for your patch. There is something to discuss/improve.

> Convert atmel i2s devicetree binding to json-schema.
> Change file name to match json-schema naming.
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner at microchip.com>
> ---
>  .../bindings/sound/atmel,sama5d2-i2s.yaml     | 83 +++++++++++++++++++
>  .../devicetree/bindings/sound/atmel-i2s.txt   | 46 ----------
>  2 files changed, 83 insertions(+), 46 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/atmel,sama5d2-i2s.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/atmel-i2s.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/atmel,sama5d2-i2s.yaml b/Documentation/devicetree/bindings/sound/atmel,sama5d2-i2s.yaml
> new file mode 100644
> index 000000000000..1cadc476565c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/atmel,sama5d2-i2s.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/atmel,sama5d2-i2s.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel I2S controller
> +
> +maintainers:
> +  - Nicolas Ferre <nicolas.ferre at microchip.com>
> +  - Alexandre Belloni <alexandre.belloni at bootlin.com>
> +  - Claudiu Beznea <claudiu.beznea at microchip.com>
> +
> +description:
> +  Atmel I2S (Inter-IC Sound Controller) bus is the standard
> +  interface for connecting audio devices, such as audio codecs.
> +
> +properties:
> +  compatible:
> +    const: atmel,sama5d2-i2s
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    description:
> +      Only the peripheral clock (pclk) is required. The generated clock (gclk)
> +      and the I2S mux clock (muxclk) are optional and should only be set together,
> +      when Master Mode is required.

Skip property description, but list and describe the items.

> +
> +  clock-names:
> +    items:
> +      - const: pclk
> +      - const: gclk
> +      - const: muxclk
> +    minItems: 1
> +
> +  dmas:
> +    description:
> +      Should be one per channel name listed in the dma-names property.
> +    maxItems: 2

Instead items+description. The description you pasted is obvious and not
helping.

> +
> +  dma-names:
> +    items:
> +      - const: tx
> +      - const: rx
> +
Best regards,
Krzysztof