[PATCH v1 1/1] ASoC: Intel: catpt: remove duplicating driver data retrieval
Andy Shevchenko
andriy.shevchenko at linux.intel.com
Sun Jul 3 00:32:43 CEST 2022
device_get_match_data() in ACPI case calls similar to acpi_match_device() API.
Hence there is no need to duplicate the call. Just check what the former
returns.
Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
---
sound/soc/intel/catpt/device.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/sound/soc/intel/catpt/device.c b/sound/soc/intel/catpt/device.c
index 85a34e37316d..21856a394c3d 100644
--- a/sound/soc/intel/catpt/device.c
+++ b/sound/soc/intel/catpt/device.c
@@ -12,13 +12,14 @@
// helping backtrack its historical background
//
-#include <linux/acpi.h>
#include <linux/dma-mapping.h>
#include <linux/interrupt.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/pci.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
+#include <linux/property.h>
#include <sound/intel-dsp-config.h>
#include <sound/soc.h>
#include <sound/soc-acpi.h>
@@ -244,8 +245,8 @@ static int catpt_acpi_probe(struct platform_device *pdev)
struct resource *res;
int ret;
- id = acpi_match_device(dev->driver->acpi_match_table, dev);
- if (!id)
+ spec = device_get_match_data(dev);
+ if (!spec)
return -ENODEV;
ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
@@ -254,10 +255,6 @@ static int catpt_acpi_probe(struct platform_device *pdev)
return -ENODEV;
}
- spec = device_get_match_data(dev);
- if (!spec)
- return -ENODEV;
-
cdev = devm_kzalloc(dev, sizeof(*cdev), GFP_KERNEL);
if (!cdev)
return -ENOMEM;
--
2.35.1
More information about the Alsa-devel
mailing list