[PATCH v2][next] ALSA: usb-audio: scarlett2: Use struct_size() helper in scarlett2_usb()

Takashi Iwai tiwai at suse.de
Tue Jan 25 15:11:48 CET 2022


On Thu, 20 Jan 2022 22:16:00 +0100,
Gustavo A. R. Silva wrote:
> 
> Make use of the struct_size() helper instead of an open-coded version,
> in order to avoid any potential type mistakes or integer overflows that,
> in the worst scenario, could lead to heap overflows.
> 
> Also, address the following sparse warnings:
> sound/usb/mixer_scarlett_gen2.c:1064:28: warning: using sizeof on a flexible structure
> sound/usb/mixer_scarlett_gen2.c:1065:29: warning: using sizeof on a flexible structure
> 
> Link: https://github.com/KSPP/linux/issues/174
> Signed-off-by: Gustavo A. R. Silva <gustavoars at kernel.org>
> ---
> Changes in v2:
>  - Use correct format specifier %zu for type size_t argument.

Applied now.  Thanks.


Takashi


More information about the Alsa-devel mailing list