[PATCH v4 8/9] ALSA: hda/realtek: Add support for HP Laptops

Takashi Iwai tiwai at suse.de
Fri Jan 21 15:39:47 CET 2022


On Fri, 21 Jan 2022 15:32:24 +0100,
Stefan Binding wrote:
> 
> Hi Takashi,
> 
> > -----Original Message-----
> > From: Alsa-devel <alsa-devel-bounces at alsa-project.org> On Behalf Of
> > Takashi Iwai
> > Sent: 20 January 2022 15:27
> > To: Stefan Binding <sbinding at opensource.cirrus.com>
> > Cc: platform-driver-x86 at vger.kernel.org; alsa-devel at alsa-project.org;
> linux-
> > acpi at vger.kernel.org; Lucas Tanure <tanureal at opensource.cirrus.com>;
> > Rafael J . Wysocki <rafael at kernel.org>; linux-kernel at vger.kernel.org;
> > Takashi Iwai <tiwai at suse.com>; Mark Gross <markgross at kernel.org>; Hans
> > de Goede <hdegoede at redhat.com>; Mark Brown <broonie at kernel.org>;
> > patches at opensource.cirrus.com; linux-spi at vger.kernel.org; Len Brown
> > <lenb at kernel.org>
> > Subject: Re: [PATCH v4 8/9] ALSA: hda/realtek: Add support for HP Laptops
> > 
> > On Thu, 20 Jan 2022 14:43:25 +0100,
> > Stefan Binding wrote:
> > >
> > > From: Lucas Tanure <tanureal at opensource.cirrus.com>
> > >
> > > Add support for two and four CS35L41 using the component
> > > binding method
> > >
> > > Signed-off-by: Lucas Tanure <tanureal at opensource.cirrus.com>
> > > Signed-off-by: Stefan Binding <sbinding at opensource.cirrus.com>
> > 
> > I guess this patch won't be applicable until ACPI or other tree syncs
> > with the latest Linus tree or sound git tree.  Must this patch be
> > merged with other patches?
> 
> In order for these laptops to work correctly, it will need all of the
> patches merged,
> including both this change and the ACPI changes - without the ACPI changes,
> some of the amps will not probe.

Well, the question is whether merging it would break other things or
not.

Currently the sound on the laptop won't work anyway, and applying this
in other tree would need the back-pull of existing HD-audio changes
from sound.git tree or Linus treee, which is often cumbersome.  The
goal is to plumb everything up in 5.17-rc as soon as possible, and
it's often faster if each tree concentrates on only the responsible
bits.


Takashi


More information about the Alsa-devel mailing list