[PATCH v2 2/6] ASoC: xilinx: xlnx_formatter_pcm: Handle sysclk setting

Mark Brown broonie at kernel.org
Mon Jan 10 15:46:04 CET 2022


On Fri, Jan 07, 2022 at 03:47:07PM -0600, Robert Hancock wrote:
> This driver did not set the MM2S Fs Multiplier Register to the proper
> value for playback streams. This needs to be set to the sample rate to
> MCLK multiplier, or random stream underflows can occur on the downstream
> I2S transmitter.
> 
> Store the sysclk value provided via the set_sysclk callback and use that
> in conjunction with the sample rate in the hw_params callback to calculate
> the proper value to set for this register.

The driver should be setting a constraint for this if the sysclk is
configured, we shouldn't end up in a situation where userspace is trying
to start a playback that will fail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220110/590ca8ff/attachment-0001.sig>


More information about the Alsa-devel mailing list