[RFC PATCH 1/3] ASoC: simple-card-utils: add support for componants provideing jack events via set_jack

[Carl Philipp Klemm]

Hi,

> I'm sorry but I don't understand what you want to do by this patch.
> Is main code of this patch asoc_simple_dai_init() update
> (= call set_jack() for all component) ?

Yes, so asoc-audio-graph-card currently only supports headphone jack plug
detection on devices that provide a simple gpio to sense plug state. The
intent of this patch is to allow the componant driver to implement jack
detection in cases where something else has to be done to sense state,
sutch as comunicating with device firmware or using a shared irq. See
the other patches in this series for an example. This is performed by
sharing the jack with the component via set_jack().
 
> ${LINUX}/sound/soc/fsl/fsl-asoc-card.c is using this function, too.
> We will have compile error without update it.

indeed, will do.

> > +		sjack = devm_kzalloc(dev, sizeof(*(*sjack)), GFP_KERNEL);
> > +		sjack_d = *sjack;
> 
> Am I misunderstanding ?
> I think you need to do here is this ?
> 
> 	-	sjack = devm_kzalloc(dev, sizeof(*(*sjack)), GFP_KERNEL);	
> 	+	*sjack = devm_kzalloc(dev, sizeof(*(*sjack)), GFP_KERNEL);

Ah yes thank you, another problem is i lack hardware to test this (the gpio) path.

-- 
Carl Philipp Klemm <philipp at uvos.xyz> <carl at uvos.xyz>