[PATCH 2/2] ALSA: core: Remove redundant 'err' variable
Meng Tang
tangmeng at uniontech.com
Sun Feb 27 08:12:53 CET 2022
Return the result from file->f_op->open() directly instead of
taking this in another redundant variable.
Signed-off-by: Meng Tang <tangmeng at uniontech.com>
---
sound/sound_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/sound_core.c b/sound/sound_core.c
index 2ee54070b2b5..e7fa820b08be 100644
--- a/sound/sound_core.c
+++ b/sound/sound_core.c
@@ -586,13 +586,12 @@ static int soundcore_open(struct inode *inode, struct file *file)
* We rely upon the fact that we can't be unloaded while the
* subdriver is there.
*/
- int err = 0;
replace_fops(file, new_fops);
if (file->f_op->open)
- err = file->f_op->open(inode,file);
+ return file->f_op->open(inode, file);
- return err;
+ return 0;
}
return -ENODEV;
}
--
2.20.1
More information about the Alsa-devel
mailing list