[PATCH 04/11] ASoC: dt-bindings: audio-graph-port: add clocks on endpoint

[Kuninori Morimoto]

Hi Rob

Thank you for your feedback

> > +      clocks:
> > +        description: Indicates system clock
> > +        $ref: /schemas/types.yaml#/definitions/phandle
>
> Is this the standard 'clocks' or you defined your own. Because 'clocks' 
> is not a 'phandle'. It's a phandle+args.

Thanks. I will fix it.

> I don't think we should have 'clocks' in endpoint nodes. Or at least we 
> don't want to endorse more cases of it. The graph describes data 
> connections. The only properties on endpoints are properties of that 
> connection. An endpoint can't really consume a clock.

Hmmm.. but, it is already implemented.

> > +      system-clock-frequency:
> > +        $ref: "simple-card.yaml#/definitions/system-clock-frequency"
> > +      system-clock-direction-out:
> > +        $ref: "simple-card.yaml#/definitions/system-clock-direction-out"
> > +      system-clock-fixed:
> > +        $ref: "simple-card.yaml#/definitions/system-clock-fixed"
(snip)
> We have standard clock bindings. Whatever you need here should use that 
> instead.

Audio-Graph-Card and Simple-Audio-Card/Card2 are sharing the code.
So, simple-card.yaml is using "definitions" to sharing it.
We can avoid duplicate definition ?


Thank you for your help !!

Best regards
---
Kuninori Morimoto