[PATCH 2/2] ASoC: max98088: fix initial dai mute state

Mark Brown broonie at kernel.org
Thu Dec 15 13:00:45 CET 2022


On Thu, Dec 15, 2022 at 10:17:47AM +0100, Marco Felsch wrote:
> On 22-12-13, Mark Brown wrote:

> > > +       snd_soc_component_update_bits(component, M98088_REG_2F_LVL_DAI1_PLAY,
> > > +               M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > > +       snd_soc_component_update_bits(component, M98088_REG_31_LVL_DAI2_PLAY,
> > > +               M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > > +

> > Won't this be broken again after suspend?  The device gets powered off
> > over suspend, then when it powers on again with the output unmuted
> > nothing will do another write since the register is already in the state
> > in the cache.

> I didn't found any suspend logic within the driver. Is this handled
> within the ASoC core?

Register save and restore for the device won't be.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20221215/24d02db8/attachment.sig>


More information about the Alsa-devel mailing list