[PATCH 0/2] ASoC: SOF: remove unregister calls from shutdown

Kai Vehmanen kai.vehmanen at linux.intel.com
Fri Dec 9 12:45:27 CET 2022


This patchset is an alternative solution to problems
reported by Ricardo Ribalda <ribalda at chromium.org> and
Zhen Ni <nizhen at uniontech.com>, as discussed in

- "[PATCH] ALSA: core: Fix deadlock when shutdown a frozen userspace"
 https://mailman.alsa-project.org/pipermail/alsa-devel/2022-November/209248.html

- "[PATCH] ASoc: SOF: Fix sof-audio-pci-intel-tgl shutdown timeout during hibernation"
  https://mailman.alsa-project.org/pipermail/alsa-devel/2022-December/209685.html

It was raised by Oliver Neukum <oneukum at suse.com> that kernel should
not let user-space stall the shutdown process in any scenario and the
unregister call in current SOF shutdown code is not right.

This series reverts the ASoC SOF patch to unregister clients and
the machine drivers at shutdown. To avoid bringing back old bugs,
the series includes a patch to fix S5 entry on certain Intel
platforms.

Kai Vehmanen (2):
  ASoC: SOF: Intel: pci-tgl: unblock S5 entry if DMA stop has failed"
  ASoC: SOF: Revert: "core: unregister clients and machine drivers in
    .shutdown"

 sound/soc/sof/core.c          |  9 -----
 sound/soc/sof/intel/hda-dsp.c | 72 +++++++++++++++++++++++++++++++++++
 sound/soc/sof/intel/hda.h     |  1 +
 sound/soc/sof/intel/tgl.c     |  2 +-
 4 files changed, 74 insertions(+), 10 deletions(-)


base-commit: e85b1f5a9769ac30f4d2f6fb1cdcd9570c38e0c1
-- 
2.38.1


More information about the Alsa-devel mailing list