[PATCH/RFC 2/2] arm64: dts: renesas: ulcb-kf: Fix pcm3168a audio codec node

Geert Uytterhoeven geert+renesas at glider.be
Fri Dec 2 13:55:44 CET 2022


"make dtbs_check":

    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec at 44: ports: 'mclk-fs' does not match any of the regexes: '^port@[0-9a-f]+$', 'pinctrl-[0-9]+'
	    From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec at 44: ports:port at 0:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected)
	    From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec at 44: ports:port at 1:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected)
	    From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml

Fix this by:
  1. Moving the "mclk-fs" property to the endpoint nodes, where it
     belongs according to .../sound/audio-graph-port.yaml,
  2. Dropping the bogus "clocks" properties.

Fixes: 80c07701d5918928 ("arm64: dts: renesas: ulcb-kf: add pcm3168 sound codec")
Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
---
Compile-tested only.
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 408871c2859d144d..8e46acbe3a203759 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -216,19 +216,18 @@ pcm3168a: audio-codec at 44 {
 				ports {
 					#address-cells = <1>;
 					#size-cells = <0>;
-					mclk-fs = <512>;
 					port at 0 {
 						reg = <0>;
 						pcm3168a_endpoint_p: endpoint {
+							mclk-fs = <512>;
 							remote-endpoint = <&rsnd_for_pcm3168a_play>;
-							clocks = <&clksndsel>;
 						};
 					};
 					port at 1 {
 						reg = <1>;
 						pcm3168a_endpoint_c: endpoint {
+							mclk-fs = <512>;
 							remote-endpoint = <&rsnd_for_pcm3168a_capture>;
-							clocks = <&clksndsel>;
 						};
 					};
 				};
-- 
2.25.1



More information about the Alsa-devel mailing list