[PATCH 3/5] ASoC: Intel: sst: Switch to standard device pages
Cezary Rojewski
cezary.rojewski at intel.com
Tue Aug 23 14:17:42 CEST 2022
On 2022-08-23 1:57 PM, Takashi Iwai wrote:
> ASoC Atom SST driver is using the continuous RAM pages with GFP_DMA
> flag for its PCM buffer, but this should work fine with the standard
> DMA pages. As a part of cleanup work, this patch replaces the buffer
> allocation to the standard device pages with SNDRV_DMA_TYPE_DEV.
>
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> ---
> sound/soc/intel/atom/sst-mfld-platform-pcm.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
> index a56dd48c045f..c75616a5fd0a 100644
> --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c
> +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
> @@ -676,10 +676,9 @@ static int sst_soc_pcm_new(struct snd_soc_component *component,
>
> if (dai->driver->playback.channels_min ||
> dai->driver->capture.channels_min) {
> - snd_pcm_set_managed_buffer_all(pcm,
> - SNDRV_DMA_TYPE_CONTINUOUS,
> - snd_dma_continuous_data(GFP_DMA),
> - SST_MIN_BUFFER, SST_MAX_BUFFER);
> + snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV,
> + pcm->card->dev,
> + SST_MIN_BUFFER, SST_MAX_BUFFER);
> }
> return 0;
> }
Reviewed-by: Cezary Rojewski <cezary.rojewski at intel.com>
More information about the Alsa-devel
mailing list