[PATCH v2] ASoC: qcom: SC7280: Update machine driver startup, shutdown callbacks

Srinivasa Rao Mandadapu quic_srivasam at quicinc.com
Tue Apr 19 15:18:49 CEST 2022


Update machine driver startup, shutdown callback functions to avoid
sound card registration failure on other platforms.
Without this change, platforms with WCD codec is failing to register
sound card.

Fixes: c5198db82d4c ("ASoC: qcom: Add driver support for ALC5682I-VS")

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam at quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu at quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu at quicinc.com>
---
Changes Since V1:
   -- Update swith case in startup, shutdown callbacks for handling all dai id's
   -- Update commit message and add Fixes tag

 sound/soc/qcom/sc7280.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/sound/soc/qcom/sc7280.c b/sound/soc/qcom/sc7280.c
index 4ef4034..834c081 100644
--- a/sound/soc/qcom/sc7280.c
+++ b/sound/soc/qcom/sc7280.c
@@ -291,13 +291,7 @@ static void sc7280_snd_shutdown(struct snd_pcm_substream *substream)
 					       SNDRV_PCM_STREAM_PLAYBACK);
 		}
 		break;
-	case MI2S_SECONDARY:
-		break;
-	case LPASS_DP_RX:
-		break;
 	default:
-		dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__,
-			cpu_dai->id);
 		break;
 	}
 }
@@ -312,14 +306,8 @@ static int sc7280_snd_startup(struct snd_pcm_substream *substream)
 	case MI2S_PRIMARY:
 		ret = sc7280_rt5682_init(rtd);
 		break;
-	case MI2S_SECONDARY:
-		break;
-	case LPASS_DP_RX:
-		break;
 	default:
-		dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__,
-			cpu_dai->id);
-		return -EINVAL;
+		break;
 	}
 	return ret;
 }
-- 
2.7.4



More information about the Alsa-devel mailing list