[PATCH 1/2] ASoC: qcom: lpass: Fix apq8016 compat string to match yaml

Srinivas Kandagatla srinivas.kandagatla at linaro.org
Tue Apr 19 11:10:28 CEST 2022



On 19/04/2022 00:09, Bryan O'Donoghue wrote:
> The documented yaml compat string for the apq8016 is
> "qcom,apq8016-lpass-cpu" not "qcom,lpass-cpu-apq8016". Looking at the other
> lpass compat strings the general form is "qcom,socnum-lpass-cpu".
> 
> We need to fix both the driver and dts to match.

Fixes tag is missing.

> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue at linaro.org>


other than that it LGTM.

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>

--srini

> ---
>   sound/soc/qcom/lpass-apq8016.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
> index 3efa133d1c64..10edc5e9c8ef 100644
> --- a/sound/soc/qcom/lpass-apq8016.c
> +++ b/sound/soc/qcom/lpass-apq8016.c
> @@ -292,7 +292,7 @@ static struct lpass_variant apq8016_data = {
>   };
>   
>   static const struct of_device_id apq8016_lpass_cpu_device_id[] __maybe_unused = {
> -	{ .compatible = "qcom,lpass-cpu-apq8016", .data = &apq8016_data },
> +	{ .compatible = "qcom,apq8016-lpass-cpu", .data = &apq8016_data },
>   	{}
>   };
>   MODULE_DEVICE_TABLE(of, apq8016_lpass_cpu_device_id);


More information about the Alsa-devel mailing list