[PATCH] slimbus: qcom: fix error check return value of platform_get_irq()
Bjorn Andersson
bjorn.andersson at linaro.org
Tue Apr 12 16:29:15 CEST 2022
On Tue 12 Apr 04:02 CDT 2022, cgel.zte at gmail.com wrote:
> From: Lv Ruyi <lv.ruyi at zte.com.cn>
>
> platform_get_irq() return negative value on failure, so null check of
> ctrl->irq is incorrect. Fix it by comparing whether it is less than zero.
>
> Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi at zte.com.cn>
Reviewed-by: Bjorn Andersson <bjorn.andersson at linaro.org>
> ---
> drivers/slimbus/qcom-ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index f04b961b96cd..b2f01e155d77 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -510,7 +510,7 @@ static int qcom_slim_probe(struct platform_device *pdev)
> }
>
> ctrl->irq = platform_get_irq(pdev, 0);
> - if (!ctrl->irq) {
> + if (ctrl->irq < 0) {
> dev_err(&pdev->dev, "no slimbus IRQ\n");
> return -ENODEV;
> }
> --
> 2.25.1
>
More information about the Alsa-devel
mailing list