[PATCH 3/4] ASoC: SOF: amd: Add psp_mbox_ready() and psp_send_cmd() callback

Mark Brown broonie at kernel.org
Fri Apr 8 10:37:07 CEST 2022


On Wed, Apr 06, 2022 at 02:40:47PM -0500, Pierre-Louis Bossart wrote:
> From: Ajit Kumar Pandey <AjitKumar.Pandey at amd.com>
> 
> We need to ensure if PSP is mbox ready before and after sending cmd
> to PSP over SMN interface. Add method to check MBOX_READY bit of PSP
> with some delay over ACP_PSP_TIMEOUT_COUNTER. Replace psp_fw_validate
> with new method psp_send_cmd() to send command via psp mailbox.

This breaks an x86 allmodconfig build with GCC 11:

/build/stage/linux/sound/soc/sof/amd/acp.c: In function ‘psp_send_cmd’:
/build/stage/linux/sound/soc/sof/amd/acp.c:176:29: error: unused variable ‘sdev’ [-Werror=unused-variable]
  176 |         struct snd_sof_dev *sdev = adata->dev;
      |                             ^~~~
cc1: all warnings being treated as errors
make[5]: *** [/build/stage/linux/scripts/Makefile.build:288: sound/soc/sof/amd/acp.o] Error 1
make[5]: Target '__build' not remade because of errors.
make[4]: *** [/build/stage/linux/scripts/Makefile.build:550: sound/soc/sof/amd] Error 2
make[4]: Target '__build' not remade because of errors.
make[3]: *** [/build/stage/linux/scripts/Makefile.build:550: sound/soc/sof] Error 2
make[3]: Target '__build' not remade because of errors.
make[2]: *** [/build/stage/linux/scripts/Makefile.build:550: sound/soc] Error 2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220408/c14b0758/attachment.sig>


More information about the Alsa-devel mailing list