[PATCH] ASoC: wm8731: Disable the regulator when probing fails
Charles Keepax
ckeepax at opensource.cirrus.com
Wed Apr 6 12:01:21 CEST 2022
On Tue, Apr 05, 2022 at 08:10:38PM +0800, Zheyu Ma wrote:
> When the driver fails during probing, the driver should disable the
> regulator, not just handle it in wm8731_hw_init().
>
> The following log reveals it:
>
> [ 17.812483] WARNING: CPU: 1 PID: 364 at drivers/regulator/core.c:2257 _regulator_put+0x3ec/0x4e0
> [ 17.815958] RIP: 0010:_regulator_put+0x3ec/0x4e0
> [ 17.824467] Call Trace:
> [ 17.824774] <TASK>
> [ 17.825040] regulator_bulk_free+0x82/0xe0
> [ 17.825514] devres_release_group+0x319/0x3d0
> [ 17.825882] i2c_device_probe+0x766/0x940
> [ 17.829198] i2c_register_driver+0xb5/0x130
>
> Signed-off-by: Zheyu Ma <zheyuma97 at gmail.com>
> ---
Mark just merged a big chain overhauling a lot of this driver, at
the very least this patch is going to require a rebase on top of
that lot.
Thanks,
Charles
More information about the Alsa-devel
mailing list