[PATCH] ASoC: dt-bindings: lpass: add binding headers for digital codecs
Srinivas Kandagatla
srinivas.kandagatla at linaro.org
Wed Sep 8 11:41:09 CEST 2021
On 06/09/2021 14:27, Srinivasa Rao Mandadapu wrote:
> +#define LPASS_CDC_DMA_RX0 6
You are only adding RX0, what happens to RX1.. RX7
TBH, skipping other entries for ex CDC_DMA_RX will end up with sparse
numbering.
Please add all the entries for CDC_DMA_RX and other ports as well.
Like:
#define LPASS_CDC_DMA_RX0 6
#define LPASS_CDC_DMA_RX1 7
#define LPASS_CDC_DMA_RX2 8
#define LPASS_CDC_DMA_RX3 9
#define LPASS_CDC_DMA_RX4 10
#define LPASS_CDC_DMA_RX5 11
#define LPASS_CDC_DMA_RX6 12
#define LPASS_CDC_DMA_RX7 13
> +#define LPASS_CDC_DMA_TX3 7
> +#define LPASS_CDC_DMA_VA0 8
You mean VA_TX0?
> +#define LPASS_MAX_PORTS 9
We really do not need this in bindings.
You could add this is some of the driver header files instead.
--srini
> +
More information about the Alsa-devel
mailing list