[PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK

Trevor Wu trevor.wu at mediatek.com
Wed Sep 1 05:48:27 CEST 2021


On Tue, 2021-08-31 at 15:18 +0200, Geert Uytterhoeven wrote:
> The Mediatek MT8195 sound hardware is only present on Mediatek MT8195
> SoCs.  Hence add a dependency on ARCH_MEDIATEK, to prevent asking the
> user about this driver when configuring a kernel without Mediatek SoC
> support.
> 
> Fixes: 6746cc858259985a ("ASoC: mediatek: mt8195: add platform
> driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
> ---
>  sound/soc/mediatek/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> index cf567a89f421b4c0..c8c815f599da90bf 100644
> --- a/sound/soc/mediatek/Kconfig
> +++ b/sound/soc/mediatek/Kconfig
> @@ -187,6 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
>  
>  config SND_SOC_MT8195
>  	tristate "ASoC support for Mediatek MT8195 chip"
> +	depends on ARCH_MEDIATEK || COMPILE_TEST
>  	select SND_SOC_MEDIATEK
>  	help
>  	  This adds ASoC platform driver support for Mediatek MT8195
> chip

Hi Geert,

Thanks for your patch first.
I really missed the dependency declaration.
But we only test "depends on ARCH_MEDIATEK" internally, maybe removing
"COMPILE_TEST" like other MTK series is better for the maintenance in
the future.

Thanks,
Trevor


More information about the Alsa-devel mailing list