[PATCH] ALSA: oxfw: fix functional regression for Mackie Onyx 1640i in v5.14 or later

[Takashi Sakamoto]

On Fri, Oct 29, 2021 at 09:49:35AM +0200, Takashi Iwai wrote:
> On Fri, 29 Oct 2021 02:30:22 +0200,
> Takashi Sakamoto wrote:
> > 
> > On Thu, Oct 28, 2021 at 05:44:37PM +0200, Takashi Iwai wrote:
> > > On Thu, 28 Oct 2021 15:03:25 +0200,
> > > Takashi Sakamoto wrote:
> > > > 
> > > > A user reports functional regression for Mackie Onyx 1640i that the device
> > > > generates slow sound with ALSA oxfw driver which supports media clock
> > > > recovery. Although the device is based on OXFW971 ASIC, it does not
> > > > transfer isochronous packet with own event frequency as expected. The
> > > > device seems to adjust event frequency according to events in received
> > > > isochronous packets in the beginning of packet streaming. This is
> > > > unknown quirk.
> > > > 
> > > > This commit fixes the regression to turn the recovery off in driver
> > > > side. As a result, nominal frequency is used in duplex packet streaming
> > > > between device and driver. For stability of sampling rate in events of
> > > > transferred isochronous packet, 4,000 isochronous packets are skipped
> > > > in the beginning of packet streaming.
> > > > 
> > > > Reference: https://github.com/takaswie/snd-firewire-improve/issues/38
> > > > Fixes: 029ffc429440 ("ALSA: oxfw: perform sequence replay for media clock recovery")
> > > > Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> > > 
> > > Thanks, applied.
> > > 
> > > 
> > > Takashi
> > 
> > Oops. I forget to add tag to stable. It's preferable to apply the
> > patch to current stable (5.14.15) and mainline RC (5.15-rc7) as well...
> > 
> > Would I request you to post the patch for the purpose alternatively?
> > (It is perhaps too late for mainline, I guess...)
> 
> You can inform Greg and Sasha once after the commit gets merged to
> Linus tree by yourself.  Just tell them the upstream commit id and
> corresponding stable trees to merge.  Usually the stable AUTOSEL
> mechanism will pick up such a commit automatically, but doing the
> manual selection is more certain and faster.

Thank you for the instruction. I've rarely used the request path for
the manual selection. Ok, when the stable AUTOSEL doesn't pick up the
commit enough later releasing mainline, I'll follow the path.


Thanks

Takashi Sakamoto