[PATCH] ASoC: cs42l51: improve error handling in cs42l51_remove()

Mark Brown broonie at kernel.org
Thu Oct 21 23:31:56 CEST 2021


On Thu, Oct 21, 2021 at 10:58:39PM +0200, Uwe Kleine-König wrote:
> On Thu, Oct 21, 2021 at 07:38:08PM +0100, Mark Brown wrote:

> > Realistically you'd have to really be trying to trigger an error here
> > and it's most likely that the system is in enough trouble if one is
> > triggered that it's just not worrying about.  I'm not sure how likely
> > it is that anyone would ever remove one of these devices in production
> > though.

> So compared to my patch you'd just drop the warning?!

The warning is fine so long as there's no action on it but use regular
regulator_bulk_disable() since as you youself said force disable is not
appropriate here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20211021/745948e6/attachment.sig>


More information about the Alsa-devel mailing list