[PATCH] ASoC: cs42l51: improve error handling in cs42l51_remove()

Mark Brown broonie at kernel.org
Thu Oct 21 20:38:08 CEST 2021


On Thu, Oct 21, 2021 at 12:36:27PM +0200, Uwe Kleine-König wrote:

> a bit unsure if regulator_bulk_force_disable() is indeed the right
> function here, its documentation specifies a different usecase.

> My motivation for this change was to make it obvious in
> cs42l51_i2c_remove() that there is no error to handle to eventually make
> i2c remove callbacks return void, too.

It would be better to just ignore the errors on disable.  Realistically
you'd have to really be trying to trigger an error here and it's most
likely that the system is in enough trouble if one is triggered that
it's just not worrying about.  I'm not sure how likely it is that anyone
would ever remove one of these devices in production though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20211021/61519800/attachment.sig>


More information about the Alsa-devel mailing list