[PATCH 1/5] ALSA: hda: Drop device-argument in NHLT functions

[Cezary Rojewski]

On 2021-10-17 9:52 AM, Takashi Iwai wrote:
> On Fri, 15 Oct 2021 18:42:33 +0200,
> Pierre-Louis Bossart wrote:
>> On 10/15/21 11:40 AM, Cezary Rojewski wrote:
>>> From: Amadeusz Sławiński <amadeuszx.slawinski at linux.intel.com>
>>>
>>> ACPI is device independent, so printing warnings using device functions
>>> is misleading. Replace dev_xxx() with pr_xxx() and remove now
>>> unnecessary argument.
>>
>> the routines in sound/hda/intel-nhtl.c are called from a specific PCI
>> device, why would you remove that information?
>>
>> This makes no sense to me.
> 
> Right, otherwise this change would confuse user, too; they'll be
> clueless about who triggers it.
> 
> It's OK to change to pr_*(), but then it should have more information
> that can be easily identified and understood what user should do.

Isn't the answer as to 'who' used it obvious, though? NHLT is used for 
I2S and DMIC endpoints only, so the question is 'limited' in the first 
place. And then, you cannot have several Intel ADSP drivers running 
simultaneously.

Also, logs found ACPI-table interface are device-less so this patch 
makes NHLT interface look more ACPI-generic alike.


Regards,
Czarek