[PATCH] ASoC: soc-component: improve error reporting for register access

Mark Brown broonie at kernel.org
Thu Oct 14 21:54:12 CEST 2021


On Thu, Oct 14, 2021 at 11:31:24AM -0500, Pierre-Louis Bossart wrote:

> BTW while looking at the code, I started to wonder if it's intentional
> that we cannot check any error code on component->driver->read(). We do
> for the write and on regmap read, which suggests this API is problematic?

I dunno about intentional but it's always been that way since ASoC was
originally merged, it's just that nobody's ever changed that as part of
one of the refactorings.  I did add error checking to the regmap read
interface when I wrote that but I wasn't about to go fixing up all the
ASoC drivers for a new API.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20211014/a56ab326/attachment.sig>


More information about the Alsa-devel mailing list