[PATCH 3/3] ASoC: Intel: sof_rt5682: use id_alt to enumerate rt5682s

[Liao, Bard]

> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> Sent: Thursday, October 7, 2021 1:25 AM
> To: Hans de Goede <hdegoede at redhat.com>; Lu, Brent
> <brent.lu at intel.com>; alsa-devel at alsa-project.org; Bard liao <yung-
> chuan.liao at linux.intel.com>
> Cc: Liam Girdwood <lgirdwood at gmail.com>; Mark Brown
> <broonie at kernel.org>; Jaroslav Kysela <perex at perex.cz>; Takashi Iwai
> <tiwai at suse.com>; Rojewski, Cezary <cezary.rojewski at intel.com>; Jie Yang
> <yang.jie at linux.intel.com>; Kai Vehmanen
> <kai.vehmanen at linux.intel.com>; Guennadi Liakhovetski
> <guennadi.liakhovetski at linux.intel.com>; Zhi, Yong <yong.zhi at intel.com>;
> Gopal, Vamshi Krishna <vamshi.krishna.gopal at intel.com>; linux-
> kernel at vger.kernel.org; Wang, Rander <rander.wang at intel.com>; Liao,
> Bard <bard.liao at intel.com>; Malik_Hsu <malik_hsu at wistron.corp-
> partner.google.com>; Yang, Libin <libin.yang at intel.com>; Charles Keepax
> <ckeepax at opensource.cirrus.com>; Paul Olaru <paul.olaru at oss.nxp.com>;
> Curtis Malainey <cujomalainey at chromium.org>; Chiang, Mac
> <mac.chiang at intel.com>; Song, Gongjun <gongjun.song at intel.com>
> Subject: Re: [PATCH 3/3] ASoC: Intel: sof_rt5682: use id_alt to enumerate
> rt5682s
> 
> 
> >> @@ -196,6 +201,7 @@ struct snd_soc_acpi_mach
> snd_soc_acpi_intel_baytrail_machines[] = {
> >>  	},
> >>  	{
> >>  		.id = "10EC5682",
> >> +		.id_alt = &rt5682s_hp,
> >>  		.drv_name = "sof_rt5682",
> >>  		.sof_fw_filename = "sof-byt.ri",
> >>  		.sof_tplg_filename = "sof-byt-rt5682.tplg",
> >
> > So this is only useful if there actually are any BYT devices using the
> "RTL5682"
> > ACPI HID, the 100+ BYT/CHT DSDTs which I've gather over time say there
> aren't any.
> >
> > Actually there also aren't any using the non alt "10EC5682" ACPI HID either...
> >
> > Bard Liao, you added this in commit f70abd75b7c6 ("ASoC: Intel: add
> > sof-rt5682 machine driver") but I wonder how useful this is. I guess it may
> be available as (and tested on?) some dev-kit.
> >
> > But I don't think there us any hardware out there in the wild using this ?
> 
> In the past we used this configuration for SOF CI tests with the MinnowBoard
> + an RT5682 eval board. We gradually fried most boards and no longer check
> this capability for each SOF PR.
> 
> So I would agree we can avoid changing anything for BYT/CHT and possibly
> APL, it'd be an untested configuration.
> 
> in other words, let's add this compatible/alt_id for platforms where we know
> it'll be used.

Agree with Pierre. "RTL5682" is a new codec which is different from
"10EC5682" and not tested on old platforms.