[PATCH] ASoC: qcom: soundwire: Enable soundwire bus clock for version 1.6

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Tue Oct 5 17:03:56 CEST 2021



>>> +        ctrl->swrm_hctl_reg = devm_ioremap(&pdev->dev,
>>> swrm_hctl_reg, 0x4);
>> if (!ctrl->swrm_hctl_reg)
>>      return -ENODEV;
>>
>> ?
> I think here error check is not required, as this change is required
> only for soundwire version 1.6 and above.

My comment had nothing to do with versions, it's just that ioremap can
fail and in general it's wise to test for errors...


More information about the Alsa-devel mailing list