[PATCH 1/2] dt-bindings: sound: tlv320adc3xxx: New codec driver

[Mark Brown]

On Mon, Oct 04, 2021 at 05:16:04PM +0200, Ricard Wanderlof wrote:
> On Mon, 4 Oct 2021, Mark Brown wrote:
> > On Mon, Oct 04, 2021 at 11:17:47AM +0200, Ricard Wanderlof wrote:

> > > +  ti,pll-mode:
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > +    enum:
> > > +      - 0 # ADC3XXX_PLL_DONT_SET - leave mode unchanged
> > > +      - 1 # ADC3XXX_PLL_ENABLE - use the on-chip PLL
> > > +      - 2 # ADC3XXX_PLL_BYPASS - do not use the on-chip PLL
> > > +      - 3 # ADC3XXX_PLL_AUTO - use on-chip PLL if possible

> > Why is this configured through the DT binding and not via the machine
> > driver as done for other drivers?

> The reason is that I want to be able to use this driver with the 
> simple-card machine driver which doesn't have any PLL control options 
> AFAIK, as the .set_sysclk callback clk_id parameter is always set to 0 
> by simple-card.

That's not a good reason to define ABI.  If you absolutely can't arrange
for your machine driver to do something sensible then you could make the
CODEC driver default to auto mode.  This is configuration, not hardware
description.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20211004/e73e1119/attachment-0001.sig>