[PATCH 1/4] ASoC: nau8824: Fix NAU8824_JACK_LOGIC define
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Mon Oct 4 16:22:30 CEST 2021
On 10/2/21 4:14 PM, Hans de Goede wrote:
> The NAU8824_JACK_LOGIC define was wrong, for active high jack-detect
> to work bit 1 needs to be set, rather then bit 0.
>
> The correct bit was found in the Android kernel source dump for
> a Cyberbook T116 tablet; and this was also tested on that same tablet.
For the series
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
> sound/soc/codecs/nau8824.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/nau8824.h b/sound/soc/codecs/nau8824.h
> index 1d7bdd8e0523..6e61405f623b 100644
> --- a/sound/soc/codecs/nau8824.h
> +++ b/sound/soc/codecs/nau8824.h
> @@ -197,7 +197,7 @@
> /* JACK_DET_CTRL (0x0D) */
> #define NAU8824_JACK_EJECT_DT_SFT 2
> #define NAU8824_JACK_EJECT_DT_MASK (0x3 << NAU8824_JACK_EJECT_DT_SFT)
> -#define NAU8824_JACK_LOGIC 0x1
> +#define NAU8824_JACK_LOGIC (0x1 << 1)
>
>
> /* INTERRUPT_SETTING_1 (0x0F) */
>
More information about the Alsa-devel
mailing list