[PATCH v3 00/16] Kcontrol get/put cleanup in Tegra drivers

Sameer Pujar spujar at nvidia.com
Thu Nov 18 08:06:55 CET 2021


There are two cleanups in the series:
 1. Use correct value type for enum controls. This is suggested by
    Takashi during review of v2.

 2. This series fixes kcontrol put callback in some of the Tegra drivers
    which are used on platforms based on Tegra210 and later. The callback
    is expected to return 1 whenever the HW update is done.

    This idea is suggested by Jaroslav. Similar suggestion came from
    Mark during review of series [0] and drivers under this were updated
    to return 1, but missed to take care of duplicate updates. This series
    updates all concerned drivers to return proper values and duplicate
    updates are filtered out.

I have added 'Suggested-by" tags accordingly.

[0] https://lore.kernel.org/linux-arm-kernel/20210913142307.GF4283@sirena.org.uk/

Changelog
=========
 v2->v3:
 -------
   * Add fixes related to wrong value type as suggested by Takashi.
     Relevant drivers are updated as part of it.

   * Use separate get/put callbacks for each mixer control. The common
     part is pushed to separate function wherever applicable, thus
     removing usage of strstr() calls. The return values are fixed
     as suggested.


 v1->v2:
 -------
   * ADMAIF, I2S, DMIC and DSPK drivers updated to take care of
     duplicate updates.
   * Similarly new patches are added for AHUB, MVC, SFC, AMX, ADX
     and Mixer drivers.

Sameer Pujar (16):
  ASoC: tegra: Fix wrong value type in ADMAIF
  ASoC: tegra: Fix wrong value type in I2S
  ASoC: tegra: Fix wrong value type in DMIC
  ASoC: tegra: Fix wrong value type in DSPK
  ASoC: tegra: Fix wrong value type in SFC
  ASoC: tegra: Fix wrong value type in MVC
  ASoC: tegra: Fix kcontrol put callback in ADMAIF
  ASoC: tegra: Fix kcontrol put callback in I2S
  ASoC: tegra: Fix kcontrol put callback in DMIC
  ASoC: tegra: Fix kcontrol put callback in DSPK
  ASoC: tegra: Fix kcontrol put callback in AHUB
  ASoC: tegra: Fix kcontrol put callback in MVC
  ASoC: tegra: Fix kcontrol put callback in SFC
  ASoC: tegra: Fix kcontrol put callback in AMX
  ASoC: tegra: Fix kcontrol put callback in ADX
  ASoC: tegra: Fix kcontrol put callback in Mixer

 sound/soc/tegra/tegra186_dspk.c   | 181 ++++++++++++++++++-----
 sound/soc/tegra/tegra210_admaif.c | 140 ++++++++++++++----
 sound/soc/tegra/tegra210_adx.c    |   3 +
 sound/soc/tegra/tegra210_ahub.c   |  11 +-
 sound/soc/tegra/tegra210_amx.c    |   3 +
 sound/soc/tegra/tegra210_dmic.c   | 184 +++++++++++++++++++-----
 sound/soc/tegra/tegra210_i2s.c    | 296 +++++++++++++++++++++++++++++---------
 sound/soc/tegra/tegra210_mixer.c  |  26 +++-
 sound/soc/tegra/tegra210_mvc.c    |  30 ++--
 sound/soc/tegra/tegra210_sfc.c    | 123 ++++++++++++----
 10 files changed, 780 insertions(+), 217 deletions(-)

-- 
2.7.4



More information about the Alsa-devel mailing list