[PATCH] ALSA: missing check for possible NULL after the call to kstrdup

Austin Kim austindh.kim at gmail.com
Tue Nov 9 01:37:42 CET 2021


From: Austin Kim <austin.kim at lge.com>

If kcalloc() return NULL due to memory starvation, it is possible for 
kstrdup() to return NULL in similar case. So add null check after the call 
to kstrdup() is made.

Signed-off-by: Austin Kim <austin.kim at lge.com>
---
 sound/synth/emux/emux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/synth/emux/emux.c b/sound/synth/emux/emux.c
index 49d1976a132c..6dab3c5bac00 100644
--- a/sound/synth/emux/emux.c
+++ b/sound/synth/emux/emux.c
@@ -88,7 +88,7 @@ int snd_emux_register(struct snd_emux *emu, struct snd_card *card, int index, ch
 	emu->name = kstrdup(name, GFP_KERNEL);
 	emu->voices = kcalloc(emu->max_voices, sizeof(struct snd_emux_voice),
 			      GFP_KERNEL);
-	if (emu->voices == NULL)
+	if ((emu->name == NULL) || (emu->voices == NULL))
 		return -ENOMEM;
 
 	/* create soundfont list */
-- 
2.20.1



More information about the Alsa-devel mailing list