[PATCH] ALSA: hda: Add Lenovo ThinkStation P340 to power_save_denylist

[Ujfalusi, Peter]

On 5/25/2021 10:19 AM, Takashi Iwai wrote:
> On Mon, 24 May 2021 17:25:33 +0200,
> Peter Ujfalusi wrote:
>>
>> On playback start there is a huge plock/pop noise via the green jack used
>> in Line out mode.
>>
>> The only way I was able to fix it to set the power_save to 0 for the
>> snd_hda_intel.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at linux.intel.com>
>> ---
>> Hi Takashi,
>>
>> Changes since RFC:
>> - Fixed up the PCI ID
>>
>> ever since I have this workstation (three weeks) the plock/pop noise on playback
>> start bugged me. So far the only solution I have found is to disable the
>> power_save which I find acceptable on a desktop compared to the pops.
>>
>> The alsa-info.sh output is can be found here:
>> http://alsa-project.org/db/?f=414b1b236fc73db386ad4f938bc3b304f6b30b05
>>
>> Missing details from alsa-info output:
>> # lspci -nnk | grep -A2 Audio
>> 00:1f.3 Audio device [0403]: Intel Corporation Comet Lake PCH cAVS [8086:06c8]
>>         DeviceName: Onboard - Sound
>>         Subsystem: Lenovo Device [17aa:1048]
>>
>> CPU: i9-10900k
>>
>> The machine have ALC623 codec and the jacks are correctly discovered and they
>> do what they supposed to be.
>> When I have the headset connected to the front and audio is routed there the
>> line out (green jack) from the back still prodices the plock/pop.
>>
>> Is there a known quirk for similar issue or a better way to handle it?
> 
> In general, this deny list is the last resort when we couldn't find
> any other way to fix the click noise.

Sure, I'm not that familiar yet with the HDA code base.

> Let's check other possibilities
> at first, e.g. setting auto_mute_via_amp flag.  This can be achieved
> even via hints in an early patching specified via "patch" option of
> snd-hda-intel module (see Documentation/sound/hda/notes.rst for some
> information).

Unfortunately the auto_mute_via_amp has no effect on the pop.
line_in_auto_switch and pin_amp_workaround have no effect either.

fwiw, a simple
cat /proc/asound/card0/codec#0

generates plock/pop.

-- 
Péter