[PATCH 4/8] iio: accel: bmc150: Add support for dual-accelerometers with a DUAL250E HID
Hans de Goede
hdegoede at redhat.com
Sat May 22 20:59:20 CEST 2021
Hi,
On 5/22/21 8:11 PM, Andy Shevchenko wrote:
> On Fri, May 21, 2021 at 11:23 PM Hans de Goede <hdegoede at redhat.com> wrote:
>>
>> The Lenovo Yoga 300-11IBR has a ACPI fwnode with a HID of DUAL250E
>> which contains I2C and IRQ resources for 2 accelerometers, 1 in the
>> display and one in the base of the device. Add support for this.
>
> ...
>
>> + board_info.irq = acpi_dev_gpio_irq_get_by(adev, NULL, 1);
>
> If NULL will be there after the series, why not to use
> acpi_dev_gpio_irq_get() directly?
I looked in drivers/gpio/gpiolib-acpi.c to see what is available
and that is an inline helper in include/linux/acpi.h, so I missed
it. I'll switch over in v2.
Regards,
Hans
More information about the Alsa-devel
mailing list