[PATCH] ALSA: usb-audio: initialize the cur variable

Takashi Iwai tiwai at suse.de
Sat May 22 08:46:10 CEST 2021


On Fri, 21 May 2021 21:46:03 +0200,
trix at redhat.com wrote:
> 
> From: Tom Rix <trix at redhat.com>
> 
> Static analysis reports this problem
> clock.c:338:10: warning: The right operand of '=='
>   is a garbage value
>     if (i == cur)
>           ^  ~~~
> 
> In __uac_clock_find_source() the goto find_others skips over
> setting of the 'cur' variable.  Since the pin loop variable
> starts with 1, it is safe to initialize cur to 0.
> 
> Signed-off-by: Tom Rix <trix at redhat.com>

Thanks for the patch, but this has been already fixed in for-next
branch.


Takashi


More information about the Alsa-devel mailing list