[PATCH 0/4] ASoC: simple-card / audio-graph re-cleanup

Guillaume Tucker guillaume.tucker at collabora.com
Mon May 10 14:27:17 CEST 2021


On 10/05/2021 02:51, Kuninori Morimoto wrote:
> 
> Hi Mark, Guillaume
> 
> KernelCI had reported that my previous cleanup patches for simple-card / audio-graph
> broke kontron-sl28-var3-ads2 sound card probing.

Could you please add this trailer, or maybe the maintainers can
add it when applying the patches?

  Reported-by: "kernelci.org bot" <bot at kernelci.org>

Thanks,
Guillaume

> It reported that it is using same name for dailink->name.
> 
> At first I thought that the issue was fsl,vf610-sai doesn't have .name on driver.
> But real issue was that cpu->dai_name removed on simple_parse_node(),
> and dailink->name was based on it.
> We need to set/get dailink->name first, and call simple_parse_node().
> This patches are do it.
> audio-graph has same issue. [4/4] patch is for it.
> 
> I hope these patches has no issues on kontron-sl28-var3-ads2.
> 
> Link: https://lore.kernel.org/r/87h7k0i437.wl-kuninori.morimoto.gx@renesas.com
> Link: https://lore.kernel.org/r/20210423175318.13990-1-broonie@kernel.org
> Link: https://lore.kernel.org/r/3ca62063-41b4-c25b-a7bc-8a8160e7b684@collabora.com
> 
> Kuninori Morimoto (4):
>   ASoC: simple-card: add simple_parse_node()
>   ASoC: simple-card: add simple_link_init()
>   ASoC: audio-graph: tidyup graph_dai_link_of_dpcm()
>   ASoC: audio-graph: tidyup dai_name seting timing
> 
>  sound/soc/generic/audio-graph-card.c |  48 +++----
>  sound/soc/generic/simple-card.c      | 187 ++++++++++++++-------------
>  2 files changed, 122 insertions(+), 113 deletions(-)
> 



More information about the Alsa-devel mailing list