[PATCH 1/2] ASoC: Intel: kbl: Add MST route change to kbl machine drivers
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Thu Mar 25 23:05:15 CET 2021
>>>
>>> - { "HDMI", NULL, "hif5 Output" },
>>> - { "DP", NULL, "hif6 Output" },
>>> -
>>
>> ... this doesn't:
>>
>> other machine drivers use this:
>>
>> {"HDMI1", NULL, "hif5-0 Output"},
>> {"HDMI2", NULL, "hif6-0 Output"},
>> {"HDMI2", NULL, "hif7-0 Output"},
>>
> Hello Pierre,
> Thanks for reviewing the patch.
> I looked through the change you suggested in bxt_da7219_max98357a.c machine, but I noticed hif6-0 Output and hif7-0 Output are having same port HDMI2, This looks not correct.
D'oh! You're right, this makes no sense to me either. I see 4
occurrences in the code.
bxt_da7219_max98357a.c: {"HDMI1", NULL, "hif5-0 Output"},
bxt_da7219_max98357a.c: {"HDMI2", NULL, "hif6-0 Output"},
bxt_da7219_max98357a.c: {"HDMI2", NULL, "hif7-0 Output"},
bxt_rt298.c: {"HDMI1", NULL, "hif5-0 Output"},
bxt_rt298.c: {"HDMI2", NULL, "hif6-0 Output"},
bxt_rt298.c: {"HDMI2", NULL, "hif7-0 Output"},
bxt_rt298.c: {"HDMI1", NULL, "hif5-0 Output"},
bxt_rt298.c: {"HDMI2", NULL, "hif6-0 Output"},
bxt_rt298.c: {"HDMI2", NULL, "hif7-0 Output"},
glk_rt5682_max98357a.c: { "HDMI1", NULL, "hif5-0 Output" },
glk_rt5682_max98357a.c: { "HDMI2", NULL, "hif6-0 Output" },
glk_rt5682_max98357a.c: { "HDMI2", NULL, "hif7-0 Output" },
Harsha and team, the HDMI2 duplicates seem like recurring copy/paste
mistakes, can you double check what the intent was? If this is indeed
unintentional, we probably need a patch per file with a Fixes tag to
have this applied to the stable kernel.
Thanks!
More information about the Alsa-devel
mailing list